Reusable Graph Traversals #10364
Merged
Reusable Graph Traversals #10364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pending quality issues with hanging indentation. I've tried various things to no avail. |
| * Topological: Parent yielded before children; child with multiple | ||
| parents yielded only after all its parents are visited. | ||
|
|
||
| * Post-order: Children yielded before its parents. |
There was a problem hiding this comment.
I think this module docstring is great. One small ask I have here is to give examples of when you would pick a particular ordering over another. I think it's easy for a developer to gloss over this without understanding why you would ever want to do, say, a post-order traversal.
There was a problem hiding this comment.
I've added some examples. They may not be great ones, so let me know if you were thinking of others. Please review.
|
👍 |
1 similar comment
|
👍 |
nasthagiri
force-pushed
the
mobile/graph_traversals
branch
from
23e9b3f
to
22c2e7e
Compare
|
jenkins run python |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have pulled out the graph traversals code into a separate PR from the Courses API PR.
Please review. @aleffert @ormsbee
FYI @jcdyer