Updated receipt page to use order endpoint #10349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintonb
force-pushed
the
multi-tenancy/update-receipt-page
branch
from
6269e91
to
bb9284e
Compare
| authentication_classes = (SessionAuthentication,) | ||
| permission_classes = (IsAuthenticated,) | ||
|
|
||
| def get(self, request, *args, **kwargs): # pylint:disable=unused-argument |
There was a problem hiding this comment.
Why does this take args and kwargs, rather than just having an explicit argument for number?
There was a problem hiding this comment.
This is the format of the parent class.
There was a problem hiding this comment.
The docs (http://www.django-rest-framework.org/api-guide/views/) use named parameters. You're also expecting number and only number as parameters in the url, so I'm not sure why having args and kwargs is a benefit.
There was a problem hiding this comment.
I stand corrected. Updated.
|
A few minor comments, but 👍 otherwise. |
clintonb
force-pushed
the
multi-tenancy/update-receipt-page
branch
2 times, most recently
from
9368188
to
1acd4a8
Compare
|
jenkins run python |
The receipt page now retrieves data for orders instead of baskets. Going forward baskets will be deleted after an order has been placed, so there should be no permanent references to baskets. Orders will continue to be persisted permanently. ECOM-2653
clintonb
force-pushed
the
multi-tenancy/update-receipt-page
branch
from
1acd4a8
to
9bb3f70
Compare
|
LGTM 👍 |
|
👍 |
clintonb
added a commit
that referenced
this pull request
Oct 28, 2015
Updated receipt page to use order endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The receipt page now retrieves data for orders instead of baskets. Going forward baskets will be deleted after an order has been placed, so there should be no permanent references to baskets. Orders will continue to be persisted permanently.
ECOM-2653