Skip to content

Commit

Permalink
fix: remove flaky test_staff_response test
Browse files Browse the repository at this point in the history
The test test_staff_response failed and then passed
and subsequent runs with the same code, and is now
considered flaky. It is being removed in accordance with
this flaky test process: https://2u-internal.atlassian.net/wiki/spaces/TE/pages/12812492/Flaky+Test+Process
Note: the Flaky+Test+Process doc should probably be more
public, but simply notes that these tests should be removed
with a ticket to allow the owning team to fix it.

Here is a link to the job where it failed and passed: 
https://github.com/openedx/edx-platform/actions/runs/3752596945/jobs/6375603154
  • Loading branch information
robrap authored Dec 21, 2022
1 parent 507b3a7 commit 6c7618f
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions lms/djangoapps/discussion/rest_api/tests/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -4099,14 +4099,6 @@ def test_default_response(self):
topics_list = get_course_topics_v2(course_key=self.course_key, user=self.user)
assert {t['id'] for t in topics_list} == set(self.topic_ids)

def test_staff_response(self):
"""
Test that the standard response contains the correct number of items
"""
topics_list = get_course_topics_v2(course_key=self.course_key, user=self.staff)
# All topic ids should be returned except for the first deleted topic id which has zero stats
assert {t['id'] for t in topics_list} == self.all_topic_ids - {self.deleted_topic_ids[0]}

def test_filtering(self):
"""
Tests that filtering by topic id works
Expand Down

2 comments on commit 6c7618f

@robrap
Copy link
Contributor Author

@robrap robrap commented on 6c7618f Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I edited in Github and messed up in the UI and committed directly to master. I will get a thumb for this.

@dianakhuang
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Please sign in to comment.