-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use days_early_for_beta
from InheritanceMixin
instead of runtime [FC-0026]
#1977
refactor: use days_early_for_beta
from InheritanceMixin
instead of runtime [FC-0026]
#1977
Conversation
…hash These files do not change their structure too often, so pointing directly to the ones that contain the most recent version number makes more sense.
Thanks for the pull request, @Agrendalath! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1977 +/- ##
==========================================
- Coverage 94.98% 94.98% -0.01%
==========================================
Files 154 154
Lines 17045 17044 -1
Branches 1611 1610 -1
==========================================
- Hits 16190 16189 -1
Misses 641 641
Partials 214 214
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@0x29a, @bradenmacdonald, this is ready for review. @pomegranited, would you like to review this as CC? |
Looks good from a quick look, but I'll let others do the bulk of the review here. I'm not a CC for this repo. |
@Agrendalath Sure thing, I'll review it this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works great, thank you @Agrendalath !
I'll merge this tomorrow if there's no objections from anyone on #cc-core-applications.
- I tested this on my devstack using the PR test instructions
- I read through the code
-
I checked for accessibility issuesN/A -- backend changes only - Includes documentation -- +💯 for updating the erroneous links in the .github templates!
- Commit structure follows OEP-0051
@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Merged and tagged: v5.0.3, and it's been pushed to pypi.
|
Thank you, @pomegranited! |
TL;DR - Use the block's property directly instead of getting it from the runtime.
What changed?
FC-0026 removes the block-specific handling from the runtime. In openedx/edx-platform#32356, we are simplifying user checks.
prepare_runtime_for_user
adds thedays_early_for_beta
attribute to the runtime, but this value is already provided by theInheritanceMixin
. We are removing this redundancy, so this makesora2
retrieve the value directly from XBlock fields.This also updates the PR template and the release process doc, as they were slightly outdated.
Developer Checklist
Testing Instructions
Days Early for Beta Users
to6000
.Edit -> SCHEDULE
and set its start dates to2030
.audit
as a beta tester.audit
user and check that you can submit the solution.Supporting information
Private-ref: BB-7448
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora