-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor add foreign key to ecu part 2 #2339
Conversation
705f1a5
to
ebf59e5
Compare
0a9470c
to
0d79f9e
Compare
Test coverage not relevant since we don't test migrations |
if 'sqlite3' in db_engine: | ||
operations = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we want this index to exist in sqlite3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I guess we don't really care, since it would just be for unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah exactly
I felt it would just be extra complexity
ebf59e5
to
65ad7f5
Compare
enterprise/migrations/0229_enterprisecustomeruser_user_fk_and_more.py
Outdated
Show resolved
Hide resolved
32c424c
to
04dbb33
Compare
Merge and deploy part 1 #2338 first!!
Then change the target branch for this PR to master.
Description
See #2338
Part 2 of adding a foreign key to ECU table.
This adds an index to the new field.
Merge checklist:
requirements/*.txt
files)base.in
if needed in production but edx-platform doesn't install ittest-master.in
if edx-platform pins it, with a matching versionmake upgrade && make requirements
have been run to regenerate requirementsmake static
has been run to update webpack bundling if any static content was updated./manage.py makemigrations
has been run./manage.py lms makemigrations
in the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgrade
in edx-platform will look for the latest version in PyPi.