Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor add foreign key to ecu part 2 #2339

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

jesperhodge
Copy link
Member

@jesperhodge jesperhodge commented Feb 19, 2025

Merge and deploy part 1 #2338 first!!

Then change the target branch for this PR to master.

Description

See #2338

Part 2 of adding a foreign key to ECU table.
This adds an index to the new field.

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production but edx-platform doesn't install it
    • test-master.in if edx-platform pins it, with a matching version
    • make upgrade && make requirements have been run to regenerate requirements
  • make static has been run to update webpack bundling if any static content was updated
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
    • This should be run from either a venv with all the lms/edx-enterprise requirements installed or if you checked out edx-enterprise into the src directory used by lms, you can run this command through an lms shell.
      • It would be ./manage.py lms makemigrations in the shell.
  • Version bumped
  • Changelog record added
  • Translations updated (see docs/internationalization.rst but also this isn't blocking for merge atm)

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in edx-platform to upgrade dependencies (including edx-enterprise)
    • Trigger the 'Upgrade one Python dependency' action against master in edx-platform with new version number to generate version bump PR
    • This must be done after the version is visible in PyPi as make upgrade in edx-platform will look for the latest version in PyPi.
    • Note: the edx-enterprise constraint in edx-platform must also be bumped to the latest version in PyPi.

@jesperhodge jesperhodge changed the base branch from master to refactor--add-foreign-key-to-ecu February 19, 2025 20:35
@jesperhodge jesperhodge mentioned this pull request Feb 25, 2025
9 tasks
@jesperhodge jesperhodge force-pushed the refactor--add-foreign-key-to-ecu branch from 705f1a5 to ebf59e5 Compare February 25, 2025 23:35
@jesperhodge jesperhodge force-pushed the refactor--add-foreign-key-to-ecu-part-2 branch from 0a9470c to 0d79f9e Compare February 25, 2025 23:40
@jesperhodge jesperhodge marked this pull request as ready for review February 25, 2025 23:40
@jesperhodge
Copy link
Member Author

Test coverage not relevant since we don't test migrations

Comment on lines +12 to +13
if 'sqlite3' in db_engine:
operations = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we want this index to exist in sqlite3?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I guess we don't really care, since it would just be for unit tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah exactly
I felt it would just be extra complexity

@jesperhodge jesperhodge force-pushed the refactor--add-foreign-key-to-ecu branch from ebf59e5 to 65ad7f5 Compare March 4, 2025 21:57
Base automatically changed from refactor--add-foreign-key-to-ecu to master March 5, 2025 17:36
@jesperhodge jesperhodge force-pushed the refactor--add-foreign-key-to-ecu-part-2 branch from 32c424c to 04dbb33 Compare March 6, 2025 15:55
@jesperhodge jesperhodge merged commit 637b399 into master Mar 6, 2025
8 of 10 checks passed
@jesperhodge jesperhodge deleted the refactor--add-foreign-key-to-ecu-part-2 branch March 6, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants