fix: Add and depend on piptools target from all IDA make targets #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`make requirements` was failing in a fresh virtualenv after the IDA cookiecutter had been fully set up (including after running `make upgrade` in a previous virtualenv). Also: - Introduce separate `piptools` target in python-template Makefile, for consistency - Add missing space in xblock Makefile
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make requirementswas failing in a fresh virtualenv after the IDA cookiecutter had been fully set up (including after runningmake upgradein a previous virtualenv).Also:
piptoolstarget in python-template Makefile, for consistencyMerge checklist:
Check off if complete or not applicable:
make requirementsfrom an empty virtualenv for cookiecutter-django-ida #317cookiecutter -o ~/tmp/ cookiecutter-django-idamake upgradein virtualenv in new repo (usual post-run setup)make requirements-- fails before this PR, succeeds after