Updated query according to model update #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhtishamShahid
force-pushed
the
ahtisham/PROD-1352
branch
5 times, most recently
from
28d090e to
69ff5b3
Compare
matthugs
approved these changes
Mar 19, 2020
Comment on lines
+63
to
+67
| program_course_enrollment = enrollment.programcourseenrollment_set.all() | ||
| if program_course_enrollment.exists(): | ||
| program_course_enrollment = program_course_enrollment.first().program_enrollment | ||
| enrollment_dict['student_uid'] = program_course_enrollment.external_user_key | ||
| else: |
There was a problem hiding this comment.
Will the program_enrollment object be the same for all the PCE? Just confirming this to avoid any incomplete/incorrect data export.
|
@AhtishamShahid Please rebase your branch as there has been new changes in master. |
awaisdar001
reviewed
Mar 20, 2020
awaisdar001
approved these changes
Mar 20, 2020
AhtishamShahid
force-pushed
the
ahtisham/PROD-1352
branch
from
69ff5b3 to
c8c8222
Compare
updated mocker and data Refector added pip version for tox test added pip version for tox test added pip version for tox test added pip version for tox test updated version updated get to first updated get to first updated version
AhtishamShahid
force-pushed
the
ahtisham/PROD-1352
branch
from
c8c8222 to
969b8f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: PROD-1352
Issue :
unable to download staff graded reports because there was recent change https://github.com/edx/edx-platform/blame/7f53a9ab9b4abfc550d3dc16e54cf63502330346/lms/djangoapps/program_enrollments/models.py#L110 so updated query and test accordingly to fix this issue.
Merge checklist:
Post merge:
finished.