EDUCATOR-4618 | Prevent csv processor objects from having duplicate columns #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
force-pushed
the
aed/fix-duplicate-columns
branch
3 times, most recently
from
11d3a96 to
619ae6e
Compare
Andytr1
approved these changes
Sep 9, 2019
iloveagent57
force-pushed
the
aed/fix-duplicate-columns
branch
2 times, most recently
from
aaa6e01 to
a4dec92
Compare
matthugs
reviewed
Sep 10, 2019
tests/test_api.py
Outdated
| @@ -216,3 +224,16 @@ def test_export(self, mocked_api, mocked_course_grade_factory): | |||
| processor = api.InterventionCSVProcessor(course_id=self.course_id) | |||
| rows = list(processor.get_iterator()) | |||
| assert len(rows) == 2 | |||
|
|
|||
| def test_columns_not_duplicated_during_init(self): | |||
There was a problem hiding this comment.
I would delete this test; we don't really have a user story for why this behavior would be important, since the interventions report isn't uploaded after being downloaded
There was a problem hiding this comment.
Ah, thanks, that's a good point.
bulk_grades/api.py
Outdated
| self._course_key = CourseKey.from_string(self.course_id) | ||
| self._subsection = UsageKey.from_string(self.subsection) if self.subsection else None | ||
| self._subsections = self._get_graded_subsections( | ||
| self._course_key, | ||
| filter_subsection=self._subsection, | ||
| filter_assignment_type=self.assignment_type | ||
| filter_assignment_type=kwargs.get('assignment_type', None), |
There was a problem hiding this comment.
Especially when you've left a big honkin' comment about what super's init does, this seems a little unnecessary
There was a problem hiding this comment.
Thanks, that's some copypasta from the change in GradeCSVProcessor.
matthugs
approved these changes
Sep 10, 2019
iloveagent57
force-pushed
the
aed/fix-duplicate-columns
branch
from
a4dec92 to
3e8dd5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openedx.atlassian.net/browse/EDUCATOR-4618
GradesCSVProcessorandInterventionCSVProcessormanage subsection column names in a sane way.pydocstyle.Merge checklist:
Post merge:
finished.