Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added support for Django 4.2 #155

Merged
merged 13 commits into from
Jul 25, 2023

Conversation

zubairshakoorarbisoft
Copy link
Contributor

@zubairshakoorarbisoft zubairshakoorarbisoft commented Jun 14, 2023

Added support for Django 4.2, to have more context on it please refer to the following issue

@zubairshakoorarbisoft zubairshakoorarbisoft requested a review from a team as a code owner June 14, 2023 14:20
@@ -45,7 +43,7 @@ jobs:
run: tox

- name: Run Coverage
if: matrix.python-version == '3.8' && matrix.toxenv=='django32-celery44'
if: matrix.python-version == '3.8' && matrix.toxenv=='django42-celery50'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: matrix.python-version == '3.8' && matrix.toxenv=='django42-celery50'
if: matrix.python-version == '3.8' && matrix.toxenv=='django42-celery53'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes added @UsamaSadiq

@zubairshakoorarbisoft zubairshakoorarbisoft changed the title fix: django42 upgrade support added fix: Added support for Django 4.2 Jul 25, 2023
@zubairshakoorarbisoft zubairshakoorarbisoft merged commit c2ffaf5 into master Jul 25, 2023
@zubairshakoorarbisoft zubairshakoorarbisoft deleted the zshkoor/django42-upgrade branch July 25, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants