-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: standardize make extract_translations #151
feat: standardize make extract_translations #151
Conversation
Refs: FC-0012 OEP-58
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
This PR needs openedx/edx-bulk-grades#151 before it's merged. Refs: FC-0012 OEP-58
Ready for your review @OmarIthawi, @brian-smith-tcril |
locales: | ||
- en # English - Source Language | ||
- ar # Arabic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only used for i18n_tools
? I'm concerned that it will break other workflows.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OmarIthawi I've noticed this pattern in many repos. 4-5 years ago, they were stripped out of edx-platform
and had this structure as a common template. Many repos including this one, don't have a transifex project for it. So, the file is not actually used. make pull_translations
doesn't find the translation anyway
We're removing all local translations soon, therefore, we can remove unused directories like this one now. Or should we always keep them until the last phase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd err on the side of removing them. So it should be fine to do so.
@mphilbrick211 this one should be good to go! It's marked as "No extra review required" on the spreadsheet so it should just be a matter of getting a CC with perms on the repo to approve/merge. |
Hi @mattcarter and @openedx/content-aurora! Would someone be able to merge this for us? Thanks! |
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR needs openedx/edx-bulk-grades#151 before it's merged. Refs: FC-0012 OEP-58
feat: standardize make extract_translations
This PR prepares the repository to comply with openedx-translations by doing the following:
bulk_grades/locale
directory, and create a symbolic link from it tobulk_grades/conf/locale
make extract_translations
to usedjango-admin
instead ofmanage.py
. And fixcd edx-bulk-grades
to the correct pathcd bulk_grades
Tested on local devstack palm to ensure that local translation still worksthere is no translation in this repoReferences
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes
For XBlocks:
conf/locale
. Therefore, we are creating a link fromconf/locale
totranslations
so Atlas can find the path without disrupting the current way of having translations locally within the XBlocks