Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix issue with constructing an error message #138

Merged
merged 3 commits into from
Dec 21, 2022
Merged

fix: fix issue with constructing an error message #138

merged 3 commits into from
Dec 21, 2022

Conversation

nsprenkle
Copy link
Contributor

@nsprenkle nsprenkle commented Dec 21, 2022 •
edited
Loading

Description: During investigation of a failed bulk grade upload, it was identified that the code to return error messaging actually had a bug, line_numbers was being referenced before it was being set. This cleans up that logic and removes that bug.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

@nsprenkle nsprenkle requested a review from a team December 21, 2022 16:17
mattcarter
mattcarter approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@nsprenkle nsprenkle merged commit aa038b3 into master Dec 21, 2022
@nsprenkle nsprenkle deleted the aurora/upload-error-fix branch December 21, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcarter mattcarter mattcarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsprenkle @mattcarter