-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: standardize make extract_translations #212
feat: standardize make extract_translations #212
Conversation
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
This PR needs openedx/edx-ace#212 before it's merged. Refs: FC-0012 OEP-58
The failing test is codecov issue |
Ready for your review @OmarIthawi @brian-smith-tcril |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other files looks good, but I'd like to double check the config.yaml
removal.
@@ -1,72 +0,0 @@ | |||
# Configuration for i18n workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shadinaif what's the impact of removing the config.yaml
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OmarIthawi it is not used, there is no transifex edx-ace
. On the other hand, config.yml
already exist in conf/locale
directory before this PR
Refs: FC-0012 OEP-58
981b790
to
7b1e5a6
Compare
@mphilbrick211 this one should be good to go! It's marked as "No extra review required" on the spreadsheet so it should just be a matter of finding a CC with perms on the repo to review/merge! |
Hi @openedx/vanguards / @zainab-amir! Would someone be able to merge this for us? Thanks! |
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR needs openedx/edx-ace#212 before it's merged. Refs: FC-0012 OEP-58
feat: standardize make extract_translations
This PR prepares the repository to comply with openedx-translations by doing the following:
locale
directory as it's not neededmake extract_translations
to usedjango-admin
instead ofmanage.py
. And fixcd edx-ace
to the correct pathcd edx_ace
Tested on local devstack palm to ensure that local translation still worksthere is no translation in this repoReferences
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes
For XBlocks:
conf/locale
. Therefore, we are creating a link fromconf/locale
totranslations
so Atlas can find the path without disrupting the current way of having translations locally within the XBlocks