Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add a basic how-to for switching to the new theme. #246

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Jan 25, 2023

With openedx/public-engineering#200 we deprecate
the edx-sphinx-theme so provide some docs for how people can migrate to
the new theme.

With https://github.com/openedx/edx-sphinx-theme/issues/184 we deprecate
the edx-sphinx-theme so provide some docs for how people can migrate to
the new theme.
Copy link
Contributor

@nedbat nedbat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits

- edx-sphinx-theme
+ sphinx-book-theme

#. Run ``make upgrade``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a likelihood that something might go wrong here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't expect it to go wrong but I think once we have people try it on a few more repos, we can probably integrate feedback if there are common issues.


html_theme_options = {

"repository_url": TODO: Add a URL Here,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"repository_url": TODO: Add a URL Here,
"repository_url": "https://github.com/openedx/the-name-of-your-repo",

This entry and the next could use some explanation

"use_repository_button": True,
"use_issues_button": True,
"use_edit_page_button": True,
"extra_footer": """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is complicated, and shouldn't be changed, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.

# Set the DJANGO_SETTINGS_MODULE if it's not set.
# Only if your project has a dependency on Django
if not os.environ.get('DJANGO_SETTINGS_MODULE'):
os.environ['DJANGO_SETTINGS_MODULE'] = 'test_utils.test_settings'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might also need some explanation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some more, let me know what you think.

"repository_url": TODO: Add a github URL Here, for example https://github.com/openedx/repo-name,
"repository_branch": TODO: Add the correct branch, for example 'main',
"path_to_docs": "docs/",
"logo_only": True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 1.0.1 of sphinx-book-theme is complaining about logo_only being an "unsupported theme option". Should this be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yea good call I created #345 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants