-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sumac Release Notes #622
base: main
Are you sure you want to change the base?
Sumac Release Notes #622
Conversation
Currently missing waffle flags for this release and likely much else :)
Thanks for the pull request, @feoh! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Here is a list of new or updated feature flags added this release that we know of on the product side:
|
Thank you! I added a line about the newly default enabled sidebar nav toggle. As to the library configuration stuff, not sure how much of that needs to be in the dev/ops section of the release notes. I'm assuming it will be covered elsewhere. Please let me know if I'm wrong about that, and give me some text you'd like to see added as I have no idea what to write for this otherwise. |
@ormsbee are there docs on library configuration that would be appropriate to link to from the developer release notes? |
Also incproproate PR feedback.
Please mention the deprecation of the "Zooming image tool" openedx/edx-platform#31436 |
All set! |
Great informational additions on Mellisearch and indexing/upgrades. Thank you! Co-authored-by: Braden MacDonald <[email protected]>
Naming changes. Thank you! Co-authored-by: Braden MacDonald <[email protected]>
Content libraries info updates. Thank you! Co-authored-by: Braden MacDonald <[email protected]>
Co-authored-by: Braden MacDonald <[email protected]>
This is for openedx/wg-build-test-release#398 since I'm unsure whether the issue got linked previously. |
Yay less MongoDB and more MySQL! Co-authored-by: Sarina Canelake <[email protected]>
clarification. Co-authored-by: Sarina Canelake <[email protected]>
Suggest collapsing "Instructor Experiences" and "Learner Experiences" sections to the following:
|
Good extension points info. Co-authored-by: Sarina Canelake <[email protected]>
Whitespace fix. Thank you! Co-authored-by: Sarina Canelake <[email protected]>
All set! Almost missed this one since you're usually so awesome about enabling my laziness so I can just push the "Commit" button on this webpage :) |
@@ -18,19 +18,53 @@ Breaking Changes | |||
**************** | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No breaking changes in Sumac. | |
I would add this line IF it is true, because otherwise reading the rendered page it's a bit unclear how the headers nest. But I want to check in on this - @arbrandes @bradenmacdonald @regisb @feanil - no breaking changes in Sumac? Who else should I tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ormsbee or @kdmccormick ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feoh I didn't mean for you to commit this at this time. We need to check if there are any breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crap itchy trigger finger. Unresolving. Will fix if people find breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feoh I didn't mean for you to commit this at this time. We need to check if there are any breaking changes.
I know, I'm sorry :) I'll fix it if people raise anything but I'm not going to create a revision to fix a thing which in fact may not be broken :) I'll stay on top of this and ensure the page reflects reality. Sorry for prematurely pulling the trigger!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is atleast openedx/edx-platform#35185 which should be captured here as a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feanil That PR is not included in Sumac as far as I can tell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you're right, it was merged just after. Right in that case, I think there is nothing that I'm aware of that's breaking in Sumac.
Yay no breaking changes! Co-authored-by: Sarina Canelake <[email protected]>
Disambiguate Mellisearch as a requirement. Co-authored-by: Braden MacDonald <[email protected]>
Improved Aspects instructions. Co-authored-by: Sarina Canelake <[email protected]>
Co-authored-by: David Ormsbee <[email protected]>
Co-authored-by: David Ormsbee <[email protected]>
As part of the Oscare Ecommerce Stack deprecation, the following repositories have been archived: |
@@ -17,20 +17,82 @@ To view the end-user facing docs, see the :doc:`feature_release_notes`. | |||
Breaking Changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Lines 5-6 there are dates for the release span (May 10 - October 23) - are those dates the accurate ones? @cmltaWt0 or @farhaanbukhsh ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like Sumac was cut on November 5th, and Redwood on May 10th. Unfortunately I can't make a suggestion here because the diff is too far up, but L6 should say
"to November 5, 2024"
Co-authored-by: Sarina Canelake <[email protected]>
I'm quite sure lots of folks haven't included things they want in the notes as of yet but this is what I have for now.
Rendered page: https://docsopenedxorg--622.org.readthedocs.build/en/622/community/release_notes/sumac/dev_op_release_notes.html