Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sumac Release Notes #622
base: main
Are you sure you want to change the base?
Sumac Release Notes #622
Changes from 5 commits
f551b19
e305eeb
0cbdc8f
c8d76fa
a6ba69c
8862dc9
d647d80
484412b
fb062a1
a094d09
01efc6b
c64064e
4bbeb8f
74b9f4b
61c1cc6
44263ca
0dc6106
d917c51
52ce181
ae099ce
2f7c1f9
c052956
7effbb6
f7c0429
fc9f81c
cca982a
970b2c8
aa5abb4
96968dc
a1056a1
111cd50
3dec30b
2d130d9
450c28a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to DEPR ticket would be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarina Thanks! Whose cage should I politely rattle to figure out which DEPR to link here please? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feanil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original DEPR was here: openedx/public-engineering#22
There is not one yet for the commerce app which we'll likely leave in for a bit longer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feanil @sarina I'm super confused about how to handle this.
The current block says:
Where do I link that DEPR in? And do I just delete the "Additional Considerations" bullet?
Signed,
-Living In A State of Confusion