feat: Re-enable image builds for arm64 for redwood #2605
Conversation
- The maintainers of `didkit` have released an update that fixes an issue where it would not build on arm64-based systems. This resolves an issue with Devstack and developers running devstack on Apple silicon-based machines. - this fix is merged in master, backporting this fix to work with redwood. openedx#2546
Faraz32123
force-pushed
the
feat/backport_arm64_docker_image_support_to_redwood
branch
from
e37c60e to
0ae7818
Compare
There was a problem hiding this comment.
@Faraz32123 are we sure we want to backport a latest master feature deps along with the simple didkit version change?
In the PR we are actually adding new deps like google-cloud-firestore - it's related to a newly introduced Verifiable Credentials feature that doesn't exists in the Redwood release.
I don't feel like it's good for us to introduce in the redwood release any new deps w/o testing.
@cmltaWt0 thanks for the timely feedback. I agree with you. We shouldn't merge the master features into redwood. So, closing this PR. |
Faraz32123
deleted the
feat/backport_arm64_docker_image_support_to_redwood
branch
|
@Faraz32123 just want to understand - will we merge just a didkit update to unblock the arm64 builds? (at least for local development). |
didkithave released an update that fixes an issue where it would not build on arm64-based systems. This resolves an issue with Devstack and developers running devstack on Apple silicon-based machines.