Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add python311 and python312 CI support #4320

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

ichintanjoshi
Copy link
Contributor

@ichintanjoshi ichintanjoshi commented Apr 8, 2024

Description

This PR contains changes for upgrading python 3.8 to python 3.11 & 3.12

Changes include :-

  • Dependencies and version upgrades

Done as a part of following :-

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 8, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 8, 2024

Thanks for the pull request, @ichintanjoshi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ichintanjoshi ichintanjoshi marked this pull request as ready for review April 9, 2024 16:22
@mphilbrick211
Copy link

Hi @openedx/course-discovery-maintainers! Would someone be able to review this for us? Thanks!

@mphilbrick211 mphilbrick211 requested a review from a team April 10, 2024 16:11
@feanil feanil linked an issue Apr 10, 2024 that may be closed by this pull request
@DawoudSheraz DawoudSheraz force-pushed the add-python311-support branch from 044ec6d to f55bf82 Compare April 15, 2024 05:49
@DawoudSheraz DawoudSheraz changed the title feat: add python311 support build: add python311 and python312 CI support Apr 15, 2024
@DawoudSheraz DawoudSheraz merged commit 8162287 into openedx:master Apr 15, 2024
24 checks passed
@openedx-webhooks
Copy link

@ichintanjoshi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@iamsobanjaved
Copy link
Contributor

This PR didn't run unit tests on python 3.11 and 3.12 versions because these versions weren't available on the docker image and the test suites just skipped unit tests. For the services that run CI on docker, we need to modify Dockerfile as well.

py311-django42: skipped because could not find python interpreter with spec(s): py311

https://github.com/openedx/course-discovery/actions/runs/8684080396/job/23811059094#step:4:1646

py312-django42: skipped because could not find python interpreter with spec(s): py312

https://github.com/openedx/course-discovery/actions/runs/8684080396/job/23811059586#step:4:1646

@feanil
Copy link
Contributor

feanil commented May 3, 2024

@iamsobanjaved or @ichintanjoshi is one of you working on fixing this?

@iamsobanjaved
Copy link
Contributor

iamsobanjaved commented May 3, 2024

Yup @feanil, almost ready, just need to clean commits, will do shortly.

Fix: #4328

@ichintanjoshi
Copy link
Contributor Author

@feanil I am coming back from vacation on Monday and will take a look into it.

@iamsobanjaved
Copy link
Contributor

#4328 is ready for review, it updates the Dockerfile to add support for Python 3.11 and 3.12

cc @feanil @ichintanjoshi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[course-discovery] Test Python 3.11 and 3.12
7 participants