-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move courses to published in CSVLoader #4319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zawan-ila
commented
Apr 8, 2024
course_discovery/apps/course_metadata/data_loaders/csv_loader.py
Outdated
Show resolved
Hide resolved
DawoudSheraz
reviewed
Apr 8, 2024
course_discovery/apps/course_metadata/data_loaders/tests/test_csv_loader.py
Show resolved
Hide resolved
DawoudSheraz
reviewed
Apr 8, 2024
course_discovery/apps/course_metadata/data_loaders/tests/test_csv_loader.py
Outdated
Show resolved
Hide resolved
DawoudSheraz
reviewed
Apr 8, 2024
AfaqShuaib09
reviewed
Apr 9, 2024
course_discovery/apps/course_metadata/data_loaders/tests/test_csv_loader.py
Outdated
Show resolved
Hide resolved
AfaqShuaib09
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻 , Tested on local changes are working fine for me
DawoudSheraz
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tested it locally but looks alright from tests perspective.
ed64293
to
5b20966
Compare
5b20966
to
426aac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-3990
Instead of LegalReview, move course runs to published state in csv loader
Testing Instructions
Run ingestion on local. Verify that the course runs are pushed to Published state, and all the seats/entitlements etc. are generated correctly (draft/non-draft)