docs: Various fixes to codejail setup instructions (copies, user) #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still doesn't work as described, as codejail's confinement still denies it the ability to create a temp directory, but it's closer. - Specify the use of `--copies` when setting up the sandbox virtualenv - Include the `user` argument to work around TMPDIR bug (#162) and link to the issue from a code comment - Use an unambiguous test for safe/usafe configuration (return the value using jailed globals, and bypass some issues with output streams) - Ensure that reading codejail checkout is permitted by apparmor Also: - Use the venv module rather than the virtualenv command, for better compatibility with varying system configurations - Don't bother activating virtualenv, just call its pip directly - Note the ordinarily-unsafe presence of find in the sudoers example - Use correct inline code syntax for rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still doesn't work as described, as codejail's confinement still denies it the ability to create a temp directory, but it's closer.
--copieswhen setting up the sandbox virtualenvuserargument to work around TMPDIR bug (Codejail cannot run without a user set #162) and link to the issue from a code commentAlso: