-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: QTI support is improved #233
base: master
Are you sure you want to change the base?
fix: QTI support is improved #233
Conversation
Thanks for the pull request, @myhailo-chernyshov-rg! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @myhailo-chernyshov-rg! Thanks for this contribution! It looks like you're contributing on behalf of Raccoon Gang - please have your manager reach out to [email protected] to have you added to Raccoon Gang's existing entity agreement with us. Thank you! |
@myhailo-chernyshov-rg it looks like the coverage has dropped substantially with this PR, can you have a look? |
Description
During the cc2olx converter usage with correct Common Cartridge course
.imscc
dumps some problems with CC XML processing were encountered. It caused by handling of special cases by the converter while the actual CC XML can be much more complicated. This PR is intended to solve the encountered problems.Also, it's found out that cc2olx completely ignores the fact that both OeX "Text Problem" and CC "Fill in the blank" support regexps, so their support is added.
Steps to reproduce
Untitled quiz item
.imscc
dump (or use the attached oneuntitled_quiz_item_dump.imscc.zip but remove
.zip
extention leaving.imscc
): ensure you have theassessment
withitem
that doesn't havetitle
attribute.For example,
KeyError
message.Section with not
root_section
identifier.imscc
dump (or use the attached onesection_with_not_root_section_identifier.imscc.zip but remove
.zip
extention leaving.imscc
): ensure you have theassessment
withsection
whichident
attribute value isn'troot_section
.For example,
respcondition
withoutcontinue
attribute.imscc
dump (or use the attached one respcondition_without_continue_attribute.imscc.zip but remove.zip
extention leaving.imscc
): ensure you have theassessment
withrespcondition
withoutcontinue
attribute.For example,
KeyError
message.material
is not direct child ofsolutionmaterial
.imscc
dump (or use the attached one material_is_not_direct_child_of_solutionmaterial.zip but remove.zip
extention leaving.imscc
): ensure you have theassessment
withitemfeedback
,itemfeedback
hassolution
child,solution
hassolutionmaterial
,material
is not a direct child ofsolutionmaterial
:flow_mat
is asolutionmaterial
child,material
is aflow_mat
child.For example,
AttributeError
message.Fill in the blank
with regexp.imscc
dump (or use the attached one fib_with_regexp.imscc.zip but remove.zip
extention leaving.imscc
): ensure you have theFill in the blank
assessment withresprocessing
that containsrespcondition
withvarsubstring
inconditionvar
.For example,
IndexError
message.Deadline
"None"