fix: add ci requirements to ensure that dependency conflicts are avoided #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
commented
Nov 21, 2023
| @@ -1,5 +1,6 @@ | |||
| # Requirements for running tests in CI | |||
| -c constraints.txt | |||
| -r quality.txt # Core and quality check dependencies | |||
There was a problem hiding this comment.
This is what I added to fix make upgrade
zacharis278
approved these changes
Nov 21, 2023
MichaelRoytman
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both requirements defined in ci.txt and quality.txt make use of
platformdirs. Because both ci.txt and quality.txt are requirements in dev.txt, ci.txt and quality.txt must share the same versions of dependencies.My solution was to explicitly make quality.txt a requirement of ci.txt, which ensures that they share the same version of
platformdirs.