feat!: add entity names to problem models #20
Conversation
Enables us to convert Superset datasets from virtual to physical datasets and pull directly from these models.
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
| actor_id, | ||
| coalesce(any(success), false) as success, | ||
| coalesce(any(attempts), 0) as attempts, | ||
| sum(num_hints_displayed) as num_hints_displayed, |
There was a problem hiding this comment.
I'm not 100% sure here, but I think the answers and hints are cumulative across events, so summing them here would effectively double them. Can you double check?
There was a problem hiding this comment.
Do you mean that there's a field that tracks number of hints shown, similar to how attempts will keep a running count of number of attempts? If so, I don't think we'd be double counting, since we're counting the number of hint/answer shown events, and not summing up a particular field.
There was a problem hiding this comment.
Oh I see, sorry I missed that 👍
| actor_id, | ||
| coalesce(any(success), false) as success, | ||
| coalesce(any(attempts), 0) as attempts, | ||
| sum(num_hints_displayed) as num_hints_displayed, |
There was a problem hiding this comment.
Oh I see, sorry I missed that 👍
|
@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Enables us to convert Superset datasets from virtual to physical datasets and pull directly from these models.