-
Notifications
You must be signed in to change notification settings - Fork 5
build: add maintance workflows #2
build: add maintance workflows #2
Conversation
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
0e3c263
to
cfd8376
Compare
README.rst
Outdated
@@ -75,24 +75,23 @@ Every time you develop something in this repo | |||
Deploying | |||
========= | |||
|
|||
TODO: How can a new user go about deploying this component? Is it just a few | |||
commands? Is there a larger how-to that should be linked here? | |||
The Open edX Sink Clickhouse component is a django plugin which doesn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Open edX Sink Clickhouse component is a django plugin which doesn't | |
The Open edX Event Sink Clickhouse component is a django plugin which doesn't |
README.rst
Outdated
PLACEHOLDER: For details on how to deploy this component, see the `deployment how-to`_ | ||
|
||
.. _deployment how-to: https://docs.openedx.org/projects/openedx-event-sink-clickhouse/how-tos/how-to-deploy-this-component.html | ||
If the service you intend to use is either the LMS or CMS, then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this means, do you mean that if it's installed as a requirement in, say, private.txt it will work out of the box?
README.rst
Outdated
.. _deployment how-to: https://docs.openedx.org/projects/openedx-event-sink-clickhouse/how-tos/how-to-deploy-this-component.html | ||
If the service you intend to use is either the LMS or CMS, then | ||
the library is installed alongside their requirements since the | ||
Nutmeg release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add something specific about the settings that need to be set for this to work here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That paragraph should be removed, and I will add the settings
cfd8376
to
2524792
Compare
@bmtcril ready for review |
@Ian2012 Sorry, this is going to need a rebase now but then I'll merge it |
2524792
to
a9f269b
Compare
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
label: needs test run |
^^I added this label just for testing purposes. Please ignore. |
Description
This PR adds maintenance workflows and upgrade requirements.
Merge checklist:
Check off if complete or not applicable: