Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Feb 15, 2024

Description

This PR adds an item in the Settings menu to allow a call of the function that exports the library tags to a CSV file.

image

Supporting Information

Testing instructions

  1. Use https://github.com/open-craft/taxonomy-sample-data/ to create some taxonomies.
  2. Go to the library page in Studio and add some tags to the units in the course using the Manage Tags option
    image
  3. Checkout THIS branch and reload the library authoring page
  4. Click on the Export Tags menu from the detail page of an existing library
  5. Check if a CSV file is downloaded with the Library structure and the tags applied to its items.

Private-ref:

@rpenido rpenido requested a review from a team as a code owner February 15, 2024 20:13
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 15, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 15, 2024

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de8582a) 53.14% compared to head (e4d7c82) 53.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #412   +/-   ##
=======================================
  Coverage   53.14%   53.14%           
=======================================
  Files          80       80           
  Lines        2021     2021           
  Branches      368      368           
=======================================
  Hits         1074     1074           
  Misses        914      914           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido I have left a question about the ENABLE_TAGGING_TAXONOMY_PAGES env flag, but this change is working as expected 👍

  • I tested this in my devstack using the PR test instructions.
  • I read through the code
  • I checked for accessibility issues by using my keyboard to navigate
  • Includes documentation N/A
  • User-facing strings are extracted for translation

const loadingStatus = LOADING_STATUS.LOADED;
setConfig({
...getConfig(),
ENABLE_TAGGING_TAXONOMY_PAGES: 'true',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't defined this ENABLE_TAGGING_TAXONOMY_PAGES env variable in this MFE yet.. I don't know if we need one.

@bradenmacdonald do we need a config flag to gate this feature here like we did for course authoring? #400 was approved by upstream without one.

@rpenido If we do need it, it needs to be added to the various .env files, src/index.jsx, and to the README.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This MFE is not part of the standard install (yet) right? I don't think we need the flag here; it can just always be on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: b7af486

@rpenido rpenido force-pushed the rpenido/fal-3611-add-export-library-tags-menu branch from c4301da to b7af486 Compare February 16, 2024 18:27
@itsjeyd
Copy link

itsjeyd commented Feb 22, 2024

@rpenido @pomegranited It looks like these changes are ready for upstream review. I'm changing status on the Contributions board accordingly, but let me know if you have any objections.

@navinkarkera Could you give this a maintainer review?

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 22, 2024
@rpenido rpenido changed the title feat: add export library tags menu feat: add export library tags menu [FC-0049] Feb 22, 2024
@rpenido rpenido marked this pull request as draft February 23, 2024 19:56
Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Looks good to me. Please update the status and we can merge this openedx/edx-platform#34246 is merged.

@rpenido rpenido marked this pull request as ready for review March 4, 2024 11:38
@rpenido
Copy link
Contributor Author

rpenido commented Mar 4, 2024

Hi @navinkarkera! Thank you for the review.
The edx-platform PR got merged!

@navinkarkera navinkarkera merged commit 4df5d5b into openedx-unsupported:master Mar 5, 2024
7 checks passed
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Mar 8, 2024
@rpenido rpenido deleted the rpenido/fal-3611-add-export-library-tags-menu branch June 3, 2024 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants