refactor: review nits + add autofocus to drawer

openedx-unsupported · Jan 3, 2024 · 0d10864 · 0d10864
1 parent 29040ac
commit 0d10864
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 17 deletions.
diff --git a/src/library-authoring/author-library/LibraryAuthoringPage.jsx b/src/library-authoring/author-library/LibraryAuthoringPage.jsx
@@ -1,5 +1,5 @@
 /* eslint-disable react-hooks/exhaustive-deps */
-import React, { useEffect, useState } from 'react';
+import React, { useEffect, useState, useRef } from 'react';
 import PropTypes from 'prop-types';
 import {
   ActionRow,
@@ -486,6 +486,8 @@ const LibraryAuthoringPageHeader = connect(
 )(injectIntl(LibraryAuthoringPageHeaderBase));
 
 const ContentTagsDrawer = ({ openContentTagsDrawer, setOpenContentTagsDrawer }) => {
+  const iFrameRef = useRef();
+
   if (openContentTagsDrawer) {
     document.body.classList.add('drawer-open');
   } else {
@@ -519,26 +521,28 @@ const ContentTagsDrawer = ({ openContentTagsDrawer, setOpenContentTagsDrawer })
     };
   }, []);
 
+  useEffect(() => {
+    if (openContentTagsDrawer && iFrameRef.current) {
+      iFrameRef.current.focus();
+    }
+  }, [openContentTagsDrawer]);
+
   // TODO: The use of an iframe in the implementation will likely change
   const renderIFrame = () => (
-    openContentTagsDrawer
-      ? (
-        <iframe
-          title="manage-tags-drawer"
-          src={`${getConfig().COURSE_AUTHORING_MFE_BASE_URL}/tagging/components/widget/${openContentTagsDrawer}`}
-          frameBorder="0"
-          style={{ width: '100%', height: '100%' }}
-        />
-      )
-      : null
+    <iframe
+      ref={iFrameRef}
+      title="manage-tags-drawer"
+      className="w-100 h-100 border-0"
+      src={`${getConfig().COURSE_AUTHORING_MFE_BASE_URL}/tagging/components/widget/${openContentTagsDrawer}`}
+    />
   );
 
-  return (
+  return openContentTagsDrawer && (
     <>
-      <div id="manage-tags-drawer" className={`drawer ${openContentTagsDrawer ? 'd-block' : ''}`}>
+      <div id="manage-tags-drawer" className="drawer">
         { renderIFrame() }
       </div>
-      <div className={`drawer-cover ${openContentTagsDrawer ? 'd-block' : ''}`} />
+      <div className="drawer-cover" />
     </>
   );
 };

diff --git a/src/library-authoring/author-library/index.scss b/src/library-authoring/author-library/index.scss
@@ -39,7 +39,6 @@
 .drawer-cover {
   z-index: 1000;
 
-  display: none;
   position: fixed;
   top: 0;
   left: 0;
@@ -51,7 +50,6 @@
 .drawer {
   z-index: 10000;
 
-  display: none;
   position: fixed;
   top: 0;
   right: 0;

diff --git a/src/library-authoring/index.scss b/src/library-authoring/index.scss
@@ -47,6 +47,6 @@ body {
 
     &:hover {
         color: white;
-        background-color: #0A3055;
+        background-color: $primary;
     }
 }