Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

chore: upgrade django-dynamic-fixture version #1194

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

cmltaWt0
Copy link
Contributor

@cmltaWt0 cmltaWt0 commented Oct 4, 2021

Description

New version of django-dynamic-fixture was introduced to support Django3.2

Upgrade issue: edx/upgrades#26

@openedx-webhooks
Copy link

Thanks for the pull request, @cmltaWt0! I've created OSPR-6095 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Oct 4, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1194 (a898c93) into master (c39874a) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1194      +/-   ##
==========================================
- Coverage   87.41%   87.27%   -0.15%     
==========================================
  Files          83       83              
  Lines        2082     2082              
  Branches      238      238              
==========================================
- Hits         1820     1817       -3     
- Misses        173      176       +3     
  Partials       89       89              
Impacted Files Coverage Δ
...lytics_dashboard/static/js/views/world-map-view.js 84.93% <0.00%> (-4.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39874a...a898c93. Read the comment docs.

@natabene
Copy link

natabene commented Oct 5, 2021

@cmltaWt0 thank you for your contribution. We will review soon.

Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schenedx schenedx merged commit 1a8e983 into openedx-unsupported:master Oct 20, 2021
@openedx-webhooks
Copy link

@cmltaWt0 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants