Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Add local requirements #6807

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Add local requirements #6807

merged 3 commits into from
Sep 21, 2022

Conversation

aht007
Copy link
Contributor

@aht007 aht007 commented Sep 15, 2022

DESC

Common/lib cleanup PR removes the local.in requirements file which makes it necessary to install local requirements as separate step. This PR adds the local requirements installation step to Ansible task.
For context: openedx/edx-platform#30890
Sandbox link: https://aht007.sandbox.edx.org

Configuration Pull Request

Make sure that the following steps are done before merging:

  • A SRE team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
  • Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • If you are updating a secure value rather than an internal one, file a SRE ticket with details.
    • Add an entry to the CHANGELOG.
  • If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
  • Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?

@aht007 aht007 marked this pull request as draft September 15, 2022 14:09
@aht007 aht007 marked this pull request as ready for review September 16, 2022 06:59
@aht007 aht007 marked this pull request as draft September 16, 2022 07:00
@aht007 aht007 force-pushed the aht007/fix-local-requirements branch from 273c14a to 1901a9a Compare September 16, 2022 07:01
@aht007 aht007 requested a review from kdmccormick September 16, 2022 11:54
@aht007
Copy link
Contributor Author

aht007 commented Sep 16, 2022

@kdmccormick I am planning to merge this PR before common/lib PR goes out. This will make us safe to merge the common/lib PR without any issues and it wouldn't cause any issues with master branch of edx-platform as well.

@kdmccormick
Copy link
Contributor

sounds good!

@UsamaSadiq UsamaSadiq marked this pull request as ready for review September 19, 2022 11:05
@UsamaSadiq
Copy link
Contributor

edx-platform build pipeline facing issues right now due to a recent Ansible upgrade by the SRE team. We'll continue with the merge and deployment of the PR once the pipeline is fixed and running again.

@UsamaSadiq UsamaSadiq merged commit c0808fe into master Sep 21, 2022
@UsamaSadiq UsamaSadiq deleted the aht007/fix-local-requirements branch September 21, 2022 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants