-
Notifications
You must be signed in to change notification settings - Fork 966
Move credentials and discovery to edxlocal for database setup #2802
Move credentials and discovery to edxlocal for database setup #2802
Conversation
PR Cover Letter
Sandbox
Testing
ReviewersIf you've been tagged for review, please check your corresponding box once you've given the 👍.
Documentation considerations
DevOps assistanceIf it's needed, or even if you suspect it might be needed, do any/all these things as early as possible. Don't surprise devops right before merging! For example, touching envs/aws.py or or envs/common.py are dead giveaways that you'll need assistance when pushing your changes out. Things that require devops attention include, but are not limited to:
FYI: Tag anyone who might be interested in this PR here. Post-review
|
This should also remove |
We're likely to need them for making docker work, but I can remove them as well, to keep the changes in a single commit. |
👍 |
@zubair-arbi you should rebase your branch on top of this one. (alternatively @jimabramson) |
@maxrothman or we can merge it to master, or to @zubair-arbi's branch. |
I'm going to squash this |
N.B. This may break docker-based devstacks. Fix TBD.
cd6f39b
to
9bc398c
Compare
@cpennington thanks for this. 👍 @maxrothman would it make sense to merge this to master and then rebase #2781 ? |
@jimabramson you can rebase on this branch, and when it eventually makes it to master it'll effectively be the same thing. |
@maxrothman ok. |
these commits got merged directly into #2781 |
N.B. This may break docker-based devstacks. Fix TBD.
@maxrothman, @jimabramson, @zubair-arbi: I think this will fix the current credentials issues.