Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nvmf/uri): use nvmf:// scheme for tcp #1789

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(nvmf/uri): use nvmf:// scheme for tcp #1789

wants to merge 1 commit into from

Conversation

dsharma-dc
Copy link
Contributor

  • Fixes issue where a nexus on old version gets an AddChild request for a child with new nvmf+tcp:// uri. It resulted in Unsupported uri scheme error.
  • Replicas always use nvmf:// uri scheme now.
  • Nexus use nvmf:// scheme when shared over tcp, and uses nvmf+rdma+tcp:// scheme when shared over rdma and tcp both.

@dsharma-dc
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Dec 19, 2024
Try #1789:
048906c
@bors-openebs-mayastor
Copy link

try

Build failed:

@dsharma-dc
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Dec 19, 2024
Try #1789:
4e8d8b9
@bors-openebs-mayastor
Copy link

try

Build failed:

@dsharma-dc
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Dec 19, 2024
Try #1789:
5669ecc
@bors-openebs-mayastor
Copy link

try

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

@Abhinandan-Purkait Abhinandan-Purkait Awaiting requested review from Abhinandan-Purkait

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsharma-dc @tiagolobocastro