-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(io-engine): listen on IPv6 unspecified by default #1743
feat(io-engine): listen on IPv6 unspecified by default #1743
Conversation
0c97a4c
to
b25fd2b
Compare
Signed-off-by: Mike Beaumont <[email protected]>
b25fd2b
to
ec1b6ec
Compare
Sorry, seems I forgot to review this somehow
Not that I know of. bors try |
tryBuild failed: |
Tests passed, but we found a coredump...
bors try |
tryBuild failed: |
Ah sorry, there was an actual failure on test
Is this just a timeout? |
Hmm I haven't been able to look at what the test does yet. I'd suspect with this change tests would either fail completely, probably at beginning, since the gRPC server wouldn't be reachable, or not at all. |
It does many concurrent rebuilds and waits for them to all complete ok
|
Here's the failure:
|
And on the target:
I thought we had fully fixed this :( |
I have seen this very rarely without this PR too over last few weeks, so I think unrelated to this change. |
bors try |
tryBuild succeeded: |
bors merge |
Build succeeded: |
Not able to fully build/test this because of SPDK issues yet but looks good in editor.
I removed the indirection with macros and strings, not sure if there was a particular need for that.
See #1731. This will need changes to the helm chart after being merged.