Feat: Cksum a replica #1557
Merged
Feat: Cksum a replica #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tiagolobocastro
commented
Dec 7, 2023
•
tiagolobocastro
commented
tiagolobocastro
requested review from
dsavitskiy,
blaisedias,
hrudaya21,
Abhinandan-Purkait,
datacore-vvarakantham and
dsharma-dc
hrudaya21
approved these changes
Dec 8, 2023
tiagolobocastro
force-pushed
the
cksum
branch
2 times, most recently
from
e13e656 to
70bbdd1
Compare
datacore-vvarakantham
approved these changes
Dec 8, 2023
Abhinandan-Purkait
approved these changes
Dec 8, 2023
tiagolobocastro
force-pushed
the
cksum
branch
from
70bbdd1 to
e7f8add
Compare
Makes use of the existing wipe infra to cksum a bdev. This means we keep existing bdev iteration and streaming notifications with a very simple change. todo: rename wipe and abstract wipe and hash a bit better Currently we add support for crc32c only Signed-off-by: Tiago Castro <[email protected]>
Updates method argument with checksum. Adds the cksum as another column. Signed-off-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
cksum
branch
from
e7f8add to
6a025b9
Compare
|
bors merge |
|
Build succeeded: |
tiagolobocastro
added a commit
that referenced
this pull request
Dec 8, 2023
1557: Feat: Cksum a replica r=tiagolobocastro a=tiagolobocastro
feat(client/test): expose test features
Signed-off-by: Tiago Castro <[email protected]>
---
feat(test/features): export test features
Signed-off-by: Tiago Castro <[email protected]>
---
feat(client/cksum): add cksum to the io-engine client
Updates method argument with checksum.
Adds the cksum as another column.
Signed-off-by: Tiago Castro <[email protected]>
---
feat(wipe/cksum): add replica cksum
Makes use of the existing wipe infra to cksum a bdev.
This means we keep existing bdev iteration and streaming notifications
with a very simple change.
todo: rename wipe and abstract wipe and hash a bit better
Currently we add support for crc32c only
Signed-off-by: Tiago Castro <[email protected]>
Co-authored-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
added a commit
that referenced
this pull request
Dec 8, 2023
1557: Feat: Cksum a replica r=tiagolobocastro a=tiagolobocastro
feat(client/test): expose test features
Signed-off-by: Tiago Castro <[email protected]>
---
feat(test/features): export test features
Signed-off-by: Tiago Castro <[email protected]>
---
feat(client/cksum): add cksum to the io-engine client
Updates method argument with checksum.
Adds the cksum as another column.
Signed-off-by: Tiago Castro <[email protected]>
---
feat(wipe/cksum): add replica cksum
Makes use of the existing wipe infra to cksum a bdev.
This means we keep existing bdev iteration and streaming notifications
with a very simple change.
todo: rename wipe and abstract wipe and hash a bit better
Currently we add support for crc32c only
Signed-off-by: Tiago Castro <[email protected]>
Co-authored-by: Tiago Castro <[email protected]>
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
1558: Cherry-pick #1556 and #1557 r=tiagolobocastro a=tiagolobocastro ci(gha): fix submodule check Ensures we fetch git history and submodules. Signed-off-by: Tiago Castro <[email protected]> --- 1557: Feat: Cksum a replica r=tiagolobocastro a=tiagolobocastro feat(client/test): expose test features Signed-off-by: Tiago Castro <[email protected]> --- feat(test/features): export test features Signed-off-by: Tiago Castro <[email protected]> --- feat(client/cksum): add cksum to the io-engine client Updates method argument with checksum. Adds the cksum as another column. Signed-off-by: Tiago Castro <[email protected]> --- feat(wipe/cksum): add replica cksum Makes use of the existing wipe infra to cksum a bdev. This means we keep existing bdev iteration and streaming notifications with a very simple change. todo: rename wipe and abstract wipe and hash a bit better Currently we add support for crc32c only Signed-off-by: Tiago Castro <[email protected]> 1556: feat(eventing): host event specific details r=datacore-vvarakantham a=datacore-vvarakantham Added host event specific details. Co-authored-by: Vandana Varakantham <[email protected]> Co-authored-by: Tiago Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.