-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various CI and CLI improvements #1554
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tiagolobocastro
commented
Nov 30, 2023
•
edited
Loading
edited
Human output parameters were setup incorrectly.. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
requested review from
hrudaya21,
Abhinandan-Purkait,
abhilashshetty04 and
dsharma-dc
November 30, 2023 19:03
bors try |
tryBuild failed: |
tiagolobocastro
force-pushed
the
fix-cli
branch
from
November 30, 2023 22:43
0c67dfb
to
a66c478
Compare
bors try |
tryBuild succeeded: |
Allows specification of a test list Allows specification of a specific scenario Adds cleanup args: --clean-all: cleans all docker-compose clusters --clean-all-exit: clean all and exit Adds cleanup on a per-test basis Signed-off-by: Tiago Castro <[email protected]>
Fixes missing test output on CI failures. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
fix-cli
branch
from
December 1, 2023 11:33
a66c478
to
55d928f
Compare
bors try |
Abhinandan-Purkait
approved these changes
Dec 1, 2023
bors cancel |
hrudaya21
approved these changes
Dec 1, 2023
bors try |
tryAlready running a review |
tiagolobocastro
force-pushed
the
fix-cli
branch
from
December 1, 2023 15:59
1acbdd6
to
018b4b8
Compare
bors try- |
bors cancel |
bors ping |
pong |
bors try |
abhilashshetty04
approved these changes
Dec 1, 2023
tiagolobocastro
force-pushed
the
fix-cli
branch
from
December 1, 2023 17:36
018b4b8
to
282df92
Compare
tryTimed out. |
tiagolobocastro
force-pushed
the
fix-cli
branch
10 times, most recently
from
December 1, 2023 23:55
5e92390
to
5f065f0
Compare
Signed-off-by: Tiago Castro <[email protected]>
Sometimes when testing we want to ^C and run something else, but this leaves cruft behind. In such case, we should cleanup to ensure environment is clean. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
fix-cli
branch
from
December 2, 2023 00:11
5f065f0
to
2732e46
Compare
bors merge |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.