fix(snapshot): reset usage cache for the parent lvol when snapshot is destroyed #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrudaya21
force-pushed
the
fix/GTM-1211
branch
6 times, most recently
from
80b4f56 to
0159b44
Compare
hrudaya21
force-pushed
the
fix/GTM-1211
branch
from
0159b44 to
62bb8e8
Compare
tiagolobocastro
approved these changes
Aug 23, 2023
hrudaya21
force-pushed
the
fix/GTM-1211
branch
from
62bb8e8 to
69c3aa8
Compare
…ol when snapshot is destroyed Signed-off-by: Hrudaya <[email protected]>
hrudaya21
force-pushed
the
fix/GTM-1211
branch
from
69c3aa8 to
1de7498
Compare
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
As a future optimisation, we could do all these actions inside SPDK, as part or post-removal logic. I |
mtzaurus
approved these changes
Aug 23, 2023
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Details:
When snapshot is destroyed, reset the usage cache for parent lvol.
When snapshot is destroyed, reset the usage cache of successor snapshots (same parent) and clones.
When the last clone is destroyed and there are any discarded snapshots leftout, as part of destroying snapshot, reset the parent Lvol usage details from cache.
If discarded Snapshot destroy happens as part of pool import, also reset the parent Lvol usage details from cache.
Why Changes Required
Volume usage information should show properly when chain of snapshots and clones are deleted. Thin provisioned lvol cache information to be cleared to show the actual allocated size when any linked lvol (snapshot/clone) is destroyed.