-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nvmf): adding support for configuring target CRD #1491
Conversation
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
When nexus Bdev is destroyed, SPDK sends out SPDK_BDEV_EVENT_REMOVE event. In response to this event, SPDK NVMF subsystem removes the corresponding namespace. When io-engine destroys the subsystem, it first stops it. Sometimes, the event for destroying nexus Bdev arrives before the subsystem is destroyed but it is stopped, which leads to an assertion in SPDK (actual_old_state == expected_old_state). Signed-off-by: Dmitry Savitskiy <[email protected]>
Signed-off-by: Dmitry Savitskiy <[email protected]>
76d40a3
to
349aafa
Compare
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Could you please put some description in the description box of this PR about the rationale behind this change? |
bors merge |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This PR adds support to allow to specify target CRDT (Command Retry Delay) via CLI/env, to prevent immediate initiator failure when a nexus fails when the last nexus child fails. This provides a period to allow control plane to recreate the nexus. The default is set to 30 sec.