Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nvmf): adding support for configuring target CRD #1491

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

dsavitskiy
Copy link
Contributor

@dsavitskiy dsavitskiy commented Aug 16, 2023

This PR adds support to allow to specify target CRDT (Command Retry Delay) via CLI/env, to prevent immediate initiator failure when a nexus fails when the last nexus child fails. This provides a period to allow control plane to recreate the nexus. The default is set to 30 sec.

@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Aug 16, 2023
@bors
Copy link
Contributor

bors bot commented Aug 16, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

io-engine/src/subsys/config/opts.rs Outdated Show resolved Hide resolved
io-engine/src/subsys/nvmf/subsystem.rs Outdated Show resolved Hide resolved
When nexus Bdev is destroyed, SPDK sends out SPDK_BDEV_EVENT_REMOVE event.
In response to this event, SPDK NVMF subsystem removes the corresponding
namespace.
When io-engine destroys the subsystem, it first stops it.
Sometimes, the event for destroying nexus Bdev arrives before the subsystem is
destroyed but it is stopped, which leads to an assertion
in SPDK (actual_old_state == expected_old_state).

Signed-off-by: Dmitry Savitskiy <[email protected]>
@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Aug 17, 2023
@bors
Copy link
Contributor

bors bot commented Aug 17, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@dsharma-dc
Copy link
Contributor

Could you please put some description in the description box of this PR about the rationale behind this change?

@dsavitskiy
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 18, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 2d3690a into openebs:develop Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants