refactor(list-rebuild): add since timestamp and name #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
requested review from
dsavitskiy,
hrudaya21 and
abhilashshetty04
tiagolobocastro
force-pushed
the
rebuild-since
branch
3 times, most recently
from
3a25f9e to
2cd9f87
Compare
hrudaya21
approved these changes
Jun 26, 2023
hrudaya21
reviewed
Jun 26, 2023
tiagolobocastro
force-pushed
the
rebuild-since
branch
2 times, most recently
from
a1e292c to
6088ce7
Compare
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jun 26, 2023
1423: refactor(list-rebuild): add since timestamp and name r=tiagolobocastro a=tiagolobocastro Allows using timestamp to avoid re-fetching all records everytime. Adds nexus name which can be useful, eg: to filter for volume uuid, which gets set as the nexus name by the control-plane. Co-authored-by: Tiago Castro <[email protected]>
|
Build failed: |
Allows using timestamp to avoid re-fetching all records everytime. Adds nexus name which can be useful, eg: to filter for volume uuid, which gets set as the nexus name by the control-plane. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
rebuild-since
branch
from
6088ce7 to
fc2395a
Compare
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using timestamp to avoid re-fetching all records everytime. Adds nexus name which can be useful, eg: to filter for volume uuid, which gets set as the nexus name by the control-plane.