fix(enospc): allow enospc nexus to fail IOs #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
requested review from
mtzaurus,
dsavitskiy,
hrudaya21 and
dsharma-dc
dsharma-dc
approved these changes
Jun 23, 2023
hrudaya21
approved these changes
Jun 23, 2023
tiagolobocastro
force-pushed
the
fix-enospc
branch
2 times, most recently
from
984a084 to
6d90c4f
Compare
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jun 23, 2023
1422: fix(enospc): allow enospc nexus to fail IOs r=tiagolobocastro a=tiagolobocastro In the case of enospc there's no guarantee we'll be able to recreate nexus with children properly again. For now let's fail IO back to initiator. Co-authored-by: Tiago Castro <[email protected]>
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jun 23, 2023
1422: fix(enospc): allow enospc nexus to fail IOs r=tiagolobocastro a=tiagolobocastro In the case of enospc there's no guarantee we'll be able to recreate nexus with children properly again. For now let's fail IO back to initiator. Co-authored-by: Tiago Castro <[email protected]>
|
bors cancel |
|
Canceled. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jun 23, 2023
1422: fix(enospc): allow enospc nexus to fail IOs r=tiagolobocastro a=tiagolobocastro In the case of enospc there's no guarantee we'll be able to recreate nexus with children properly again. For now let's fail IO back to initiator. Co-authored-by: Tiago Castro <[email protected]>
|
Timed out. |
In the case of enospc there's no guarantee we'll be able to recreate nexus with children properly again. For now let's fail IO back to initiator. Also once we're frozen don't allow any operations, similar to Shutdown. todo: Should we just transition to Shutdown? Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
fix-enospc
branch
from
6d90c4f to
7d2dffe
Compare
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of enospc there's no guarantee we'll be able to recreate nexus with children properly again.
For now let's fail IO back to initiator.