fix(fs/shutdown): pause nexus when faulted #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
requested review from
mtzaurus,
dsavitskiy,
hrudaya21 and
dsharma-dc
mtzaurus
approved these changes
Jun 13, 2023
hrudaya21
approved these changes
Jun 13, 2023
dsharma-dc
approved these changes
Jun 13, 2023
When the last healthy child of a nexus is faulted, errors are propagated up the stack causing the filesystem to shutdown itself down. Instead I propose that we simply leave the nexus in a paused state, allowing the initiator to start the re-connection cycle, giving us some “time” to recreate the nexus again when the replica is available again. todo: we might want to add a time-limit after which we resort to failing IOs? Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
xfs-shutdown
branch
from
28c8d7d to
3142d3e
Compare
Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
xfs-shutdown
branch
from
3142d3e to
b6e488f
Compare
dsharma-dc
approved these changes
Jun 13, 2023
Signed-off-by: Tiago Castro <[email protected]>
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the last healthy child of a nexus is faulted, errors are propagated up the stack causing the filesystem to shutdown itself down.
Instead I propose that we simply leave the nexus in a paused state, allowing the initiator to start the re-connection cycle, giving us some “time” to recreate the nexus again when the replica is available again.
todo: we might want to add a time-limit after which we resort to failing IOs?