fix(nvmx): fixing async qpair connection bugs #1405
Conversation
dsavitskiy
force-pushed
the
feature/async-qpair-crash
branch
from
0c5d00d to
40c887e
Compare
|
bors try |
tryBuild failed: |
dsavitskiy
force-pushed
the
feature/async-qpair-crash
branch
from
40c887e to
a75f2d9
Compare
io-engine/src/bdev/nvmx/channel.rs
Outdated
|
|
||
| fn remove_qpair(&mut self) -> Option<QPair> { | ||
| if let Some(q) = &self.qpair { | ||
| debug!("removing qpair {q:p}", q = q.as_ptr()); |
There was a problem hiding this comment.
should this be trace?
io-engine/src/bdev/nvmx/qpair.rs
Outdated
| .parse() | ||
| .unwrap() |
There was a problem hiding this comment.
is to_string() enough ?
There was a problem hiding this comment.
ah, indeed. I just copied this piece of code over from the old implementation.
dsavitskiy
force-pushed
the
feature/async-qpair-crash
branch
2 times, most recently
from
e9e78a5 to
46671c5
Compare
|
bors try |
tryMerge conflict. |
dsavitskiy
force-pushed
the
feature/async-qpair-crash
branch
from
46671c5 to
6268470
Compare
Signed-off-by: Dmitry Savitskiy <[email protected]>
dsavitskiy
force-pushed
the
feature/async-qpair-crash
branch
from
6268470 to
537ac2f
Compare
|
bors try |
This commit fixes a use-after-free in a situation when a qpair instance was dropped while an async connection was in progress. A component-level test for such situation is added. Signed-off-by: Dmitry Savitskiy <[email protected]>
dsavitskiy
force-pushed
the
feature/async-qpair-crash
branch
from
537ac2f to
3875ce9
Compare
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
No description provided.