fix: trace errno in lvol destroy error message

Also return verbose errors in the grpc status for the catch all internal errors.

Signed-off-by: Tiago Castro <[email protected]>

mayastor/src/bdev/nexus/nexus_bdev.rs

@@ -348,7 +348,7 @@ impl From<Error> for tonic::Status {
             Error::ChildNotFound {
                 ..
             } => Status::not_found(e.to_string()),
-            e => Status::new(Code::Internal, e.to_string()),
+            e => Status::new(Code::Internal, e.verbose()),
         }
     }
 }

mayastor/src/grpc/mayastor_grpc.rs

@@ -53,6 +53,7 @@ use tonic::{Request, Response, Status};
 #[derive(Debug)]
 struct UnixStream(tokio::net::UnixStream);
 
+use crate::bdev::nexus::VerboseError;
 use ::function_name::named;
 use std::{panic::AssertUnwindSafe, pin::Pin};
 use version_info::raw_version_string;
@@ -174,7 +175,7 @@ impl From<LvsError> for Status {
             LvsError::InvalidBdev {
                 source, ..
             } => source.into(),
-            _ => Status::internal(e.to_string()),
+            _ => Status::internal(e.verbose()),
         }
     }
 }

mayastor/src/lvs/lvol.rs

@@ -308,9 +308,10 @@ impl Lvol {
         r.await
             .expect("lvol destroy callback is gone")
             .to_result(|e| {
-                warn!("error while destroying lvol {}", name);
+                let errno = Errno::from_i32(e);
+                warn!("error while destroying lvol {}: {}", name, errno);
                 Error::RepDestroy {
-                    source: Errno::from_i32(e),
+                    source: errno,
                     name: name.clone(),
                 }
             })?;