feat: make bdev share protocol argument as an option

Signed-off-by: shubham <[email protected]>
openebs · Feb 26, 2021 · 8c81fa9 · 8c81fa9
1 parent a6c8231
commit 8c81fa9
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/mayastor/src/bin/mayastor-client/bdev_cli.rs b/mayastor/src/bin/mayastor-client/bdev_cli.rs
@@ -37,12 +37,10 @@ pub fn subcommands<'a, 'b>() -> App<'a, 'b> {
     let share = SubCommand::with_name("share")
         .about("share the given bdev")
         .arg(Arg::with_name("name").required(true).index(1))
-        .arg(
-            Arg::with_name("protocol")
-                .help("the protocol to used to share the given bdev")
-                .required(false)
-                .default_value("nvmf")
-                .value_names(&["nvmf", "iscsi"]),
+        .arg(Arg::from_usage("<protocol> 'the protocol to used to share the given bdev'")
+                .short("p")
+                .possible_values(&["nvmf", "iscsi"])
+                .default_value("nvmf"),
         );
 
     let unshare = SubCommand::with_name("unshare")