Skip to content

Commit

Permalink
fix(nvme/kato): adjust to spdk minimum
Browse files Browse the repository at this point in the history
SPDK minimum KATO is 10s, so setting 1s is pointless.
Also the spec does suggest setting a sufficiently high KATO on a fabric, so perhaps
we might want to consider increasing it in the future.

Signed-off-by: Tiago Castro <[email protected]>
  • Loading branch information
tiagolobocastro committed Nov 23, 2023
1 parent 5bf8f36 commit 42c6bc8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion io-engine/src/subsys/config/opts.rs
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ impl Default for NvmeBdevOpts {
),
keep_alive_timeout_ms: time_try_from_env(
"NVME_KATO",
1_000,
10_000,
TimeUnit::MilliSeconds,
),
transport_retry_count: try_from_env("NVME_RETRY_COUNT", 0),
Expand Down

0 comments on commit 42c6bc8

Please sign in to comment.