Merge #1356

1356: feat(pool): pool committed size r=tiagolobocastro a=dsavitskiy



Co-authored-by: Dmitry Savitskiy <[email protected]>

io-engine-tests/src/pool.rs

@@ -2,6 +2,7 @@ pub use super::compose::rpc::v1::pool::Pool;
 use super::{
     compose::rpc::v1::{
         pool::{CreatePoolRequest, ListPoolOptions},
+        replica::{ListReplicaOptions, Replica},
         SharedRpcHandle,
         Status,
     },
@@ -91,6 +92,20 @@ impl PoolBuilder {
                 Status::new(Code::NotFound, format!("Pool '{uuid}' not found"))
             })
     }
+
+    pub async fn get_replicas(&self) -> Result<Vec<Replica>, Status> {
+        self.rpc()
+            .borrow_mut()
+            .replica
+            .list_replicas(ListReplicaOptions {
+                name: None,
+                poolname: None,
+                uuid: None,
+                pooluuid: self.uuid.clone(),
+            })
+            .await
+            .map(|r| r.into_inner().replicas)
+    }
 }
 
 pub async fn list_pools(rpc: SharedRpcHandle) -> Result<Vec<Pool>, Status> {

io-engine/src/grpc/v1/pool.rs

@@ -144,6 +144,7 @@ impl From<Lvs> for Pool {
             state: PoolState::PoolOnline.into(),
             capacity: l.capacity(),
             used: l.used(),
+            committed: l.committed(),
             pooltype: PoolType::Lvs as i32,
         }
     }

io-engine/src/lvs/lvs_store.rs

@@ -187,6 +187,12 @@ impl Lvs {
         self.capacity() - self.available()
     }
 
+    /// returns committed size
+    pub fn committed(&self) -> u64 {
+        self.lvols()
+            .map_or(0, |vols| vols.fold(0, |acc, r| acc + r.size()))
+    }
+
     /// returns the base bdev of this lvs
     pub fn base_bdev(&self) -> UntypedBdev {
         let p =

io-engine/tests/nexus_thin.rs

@@ -127,4 +127,15 @@ async fn nexus_thin_create_2() {
         .with_replica(&t.repl_1_thin);
 
     nex_0.create().await.unwrap();
+
+    // Check pool committed size.
+    let total_capacity = t
+        .pool_0
+        .get_replicas()
+        .await
+        .unwrap()
+        .into_iter()
+        .fold(0, |acc, r| acc + r.size);
+    let p = t.pool_0.get_pool().await.unwrap();
+    assert_eq!(p.committed, total_capacity);
 }