Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry Pick PR 574 #575

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Cherry Pick PR 574 #575

merged 1 commit into from
Dec 3, 2024

Conversation

tiagolobocastro
Copy link
Contributor

If CSI driver being used supports online expansion, it might be desirable to set handle-volume-inuse-error to false - to save costs associated with watching all pods in the cluster.

Description

Since we support online expansion, it makes sense to disable it.

Motivation and Context

Reduce memory consumption on clusters with large number of pods.

Regression

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.

@tiagolobocastro
fix(csi-resizer): lower memory usage on large clusters
dcd458b 
If CSI driver being used supports online expansion, it might be desirable
to set handle-volume-inuse-error to false - to save costs associated with
watching all pods in the cluster.

Signed-off-by: Tiago Castro <[email protected]>
@tiagolobocastro
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 4802e8e into release/2.7 Dec 3, 2024
5 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the cherry-csi branch December 3, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niladrih niladrih niladrih approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@sinhaashish sinhaashish Awaiting requested review from sinhaashish

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiagolobocastro @Abhinandan-Purkait @niladrih