feat(chart): add requestTimeout for core-agent container #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-shalbanov-fntext
force-pushed
the
develop
branch
from
dfd3dce to
25285b2
Compare
oleksandr-shalbanov-fntext
force-pushed
the
develop
branch
2 times, most recently
from
2a864b9 to
6035dd6
Compare
tiagolobocastro
approved these changes
Nov 21, 2024
niladrih
approved these changes
Nov 23, 2024
Abhinandan-Purkait
approved these changes
Nov 25, 2024
sinhaashish
approved these changes
Nov 25, 2024
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
569: feat(chart): add requestTimeout for core-agent container r=tiagolobocastro a=oleksandr-shalbanov-fntext ## Description Adding helm chart value .agents.core.requestTimeout to be able to configure core agent timeout. ## Motivation and Context This is to resolve [#3805](openebs/openebs#3805) issue. ## Regression No ## How Has This Been Tested? Installed OpenEBS with helm chart to my test environment ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - [x] My code follows the code style of this project. - [x] My change requires a change to the documentation. - [x] I have updated the documentation accordingly. - [ ] I have added unit tests to cover my changes. Co-authored-by: Oleksandr Shalbanov <[email protected]>
|
Build failed: |
|
@oleksandr-shalbanov-fntext please run docs script to update the docs: |
Signed-off-by: Oleksandr Shalbanov <[email protected]>
oleksandr-shalbanov-fntext
force-pushed
the
develop
branch
from
6035dd6 to
6096a56
Compare
|
bors d+ |
|
✌️ oleksandr-shalbanov-fntext can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
569: feat(chart): add requestTimeout for core-agent container r=oleksandr-shalbanov-fntext a=oleksandr-shalbanov-fntext ## Description Adding helm chart value .agents.core.requestTimeout to be able to configure core agent timeout. ## Motivation and Context This is to resolve [#3805](openebs/openebs#3805) issue. ## Regression No ## How Has This Been Tested? Installed OpenEBS with helm chart to my test environment ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - [x] My code follows the code style of this project. - [x] My change requires a change to the documentation. - [x] I have updated the documentation accordingly. - [ ] I have added unit tests to cover my changes. Co-authored-by: Oleksandr Shalbanov <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried. Additional information: Response status code: 422
{"message":"4 of 5 required status checks are queued.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"} |
|
Seems the github actions for the Merge commit are stuck for some reason... |
|
@tiagolobocastro So should I retrigger the build? |
Yeah I guess so |
|
bors r+ |
|
Build succeeded: |
|
Thanks @oleksandr-shalbanov-fntext ! |
|
FYI - openebs/mayastor-control-plane#887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding helm chart value .agents.core.requestTimeout to be able to configure core agent timeout.
Motivation and Context
This is to resolve #3805 issue.
Regression
No
How Has This Been Tested?
Installed OpenEBS with helm chart to my test environment
Types of changes
Checklist: