Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade basic sanity test #564

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Upgrade basic sanity test #564

merged 2 commits into from
Nov 13, 2024

Conversation

niladrih
Copy link
Member

@niladrih niladrih commented Oct 30, 2024

Changes:

  • Adds a pytest for testing basic sanity in upgrade
  • Add enhancement to the scripts/helm/install.sh script to support installing from a hosted registry
  • Add a script to format python files

shell.nix Show resolved Hide resolved
tests/bdd/common/assertion.py Outdated Show resolved Hide resolved
tests/bdd/common/kubectl_mayastor.py Outdated Show resolved Hide resolved
@niladrih
Copy link
Member Author

Moving @tiagolobocastro's review comment here so that I can track it.

       install_command = []
       if source == ChartSource.HOSTED:
           repo_name = repo_add_mayastor()

ah ok, we want to be able to do both, got it.
Let's change the script to support this as well, rather than have separate commands here

@niladrih niladrih added the wip Indicates that this is a work in progress label Nov 4, 2024
@niladrih niladrih marked this pull request as draft November 4, 2024 19:39
@niladrih niladrih marked this pull request as ready for review November 7, 2024 11:26
@niladrih niladrih removed the wip Indicates that this is a work in progress label Nov 7, 2024
tests/bdd/common/helm.py Outdated Show resolved Hide resolved
tests/bdd/features/test_upgrade.py Outdated Show resolved Hide resolved
tests/bdd/requirements.txt Outdated Show resolved Hide resolved
pytest.ini Show resolved Hide resolved
@niladrih niladrih force-pushed the upgrade-tests branch 4 times, most recently from ef444c4 to 65eb518 Compare November 10, 2024 17:01
@niladrih
Copy link
Member Author

Moving @tiagolobocastro's review comment here so that I can track it.

       install_command = []
       if source == ChartSource.HOSTED:
           repo_name = repo_add_mayastor()

ah ok, we want to be able to do both, got it.
Let's change the script to support this as well, rather than have separate commands here

This change is added to this PR.

@niladrih niladrih force-pushed the upgrade-tests branch 9 times, most recently from bf14382 to cb7fd97 Compare November 11, 2024 09:16
@niladrih niladrih force-pushed the upgrade-tests branch 4 times, most recently from 12f0ec1 to 5060a49 Compare November 13, 2024 08:49
@niladrih
Copy link
Member Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Nov 13, 2024
564: Upgrade basic sanity test r=niladrih a=niladrih

Changes:
- Adds a pytest for testing basic sanity in upgrade
- Add enhancement to the scripts/helm/install.sh script to support installing from a hosted registry
- Add a script to format python files

Co-authored-by: Niladri Halder <[email protected]>
@bors-openebs-mayastor
Copy link
Contributor

This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried.

Additional information:

Response status code: 422
{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"}

@niladrih
Copy link
Member Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 797603a into develop Nov 13, 2024
7 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the upgrade-tests branch November 13, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants