Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): support IPv6 Pod IPs #552

Merged
merged 1 commit into from
Oct 23, 2024
Merged

feat(helm): support IPv6 Pod IPs #552

merged 1 commit into from
Oct 23, 2024

Conversation

michaelbeaumont
Copy link
Contributor

Incorporates all the changes from openebs/mayastor#1731 into the chart. Depends on the PRs there.

Description

Use the new separated IP, port args.

Motivation and Context

See the linked issue.

Regression

No

How Has This Been Tested?

Hasn't yet

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.

@michaelbeaumont michaelbeaumont marked this pull request as draft October 7, 2024 21:55
@michaelbeaumont michaelbeaumont mentioned this pull request Oct 7, 2024
Open
@tiagolobocastro
Copy link
Contributor

@michaelbeaumont I've re-ran the actions since your other PRs merged, and looks like k8s ci now passes, but seems somehow the k8s-ci-vm is failing to download the jaeger operator chart

@michaelbeaumont michaelbeaumont marked this pull request as ready for review October 18, 2024 17:34
@michaelbeaumont michaelbeaumont changed the title feat: support IPv6 Pod IPs feat(helm): support IPv6 Pod IPs Oct 18, 2024
@tiagolobocastro
Copy link
Contributor

@michaelbeaumont could you please rebase rather Merge into?

@michaelbeaumont
feat: support IPv6 Pod IPs
f2dd265 
Signed-off-by: Mike Beaumont <[email protected]>
@michaelbeaumont
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Oct 19, 2024
Try #552:
7c7e2e9
@bors-openebs-mayastor
Copy link
Contributor

try

Build succeeded:

@michaelbeaumont
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 5c0033a into openebs:develop Oct 23, 2024
7 checks passed
@michaelbeaumont michaelbeaumont deleted the feat/ipv6-pods-chart branch October 23, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@dsharma-dc dsharma-dc dsharma-dc approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@sinhaashish sinhaashish Awaiting requested review from sinhaashish

@niladrih niladrih Awaiting requested review from niladrih

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelbeaumont @tiagolobocastro @Abhinandan-Purkait @dsharma-dc