Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(naming): make it easier to use custom names #504

Merged
merged 1 commit into from
May 16, 2024
Merged

feat(naming): make it easier to use custom names #504

merged 1 commit into from
May 16, 2024

Conversation

tiagolobocastro
Copy link
Contributor

Would still require a lot of manual changes though as values are spread on many .yaml files, ie values.yaml product.yaml doc.yaml... A script would be the required to make all changes.

Description

Motivation and Context

Regression

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.

sinhaashish
sinhaashish approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit-pick , otherwise lgtm

constants/Cargo.toml Show resolved Hide resolved
@tiagolobocastro
feat(naming): make it easier to use custom names
163bc98 
Would still require a lot of manual changes though as values are spread on many
.yaml files, ie values.yaml product.yaml doc.yaml...
A script would be the required to make all changes.

Signed-off-by: Tiago Castro <[email protected]>
@tiagolobocastro
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 4c8ad15 into develop May 16, 2024
5 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the custom branch May 16, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@dsharma-dc dsharma-dc dsharma-dc approved these changes

@sinhaashish sinhaashish sinhaashish approved these changes

@avishnu avishnu Awaiting requested review from avishnu

@niladrih niladrih Awaiting requested review from niladrih

@datacore-vvarakantham datacore-vvarakantham Awaiting requested review from datacore-vvarakantham

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiagolobocastro @sinhaashish @Abhinandan-Purkait @dsharma-dc