Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(helm): add helm var to control safe mounts #491

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

tiagolobocastro
Copy link
Contributor

Can be used to either force safeMounts ("always") or to disable them ("no")

Description

Motivation and Context

Regression

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.

Can be used to either force safeMounts ("always") or to disable them ("no")

Signed-off-by: Tiago Castro <[email protected]>
Copy link
Member

@avishnu avishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tiagolobocastro
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit c6b81bc into release/2.6 Apr 18, 2024
5 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the fix-mount-iter branch April 18, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants