fix(upgrade-job): use default value for missing values with helm 3.13 & 3.14 #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… & 3.14 Signed-off-by: Niladri Halder <[email protected]>
Abhinandan-Purkait
approved these changes
Apr 11, 2024
tiagolobocastro
approved these changes
Apr 11, 2024
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
479: fix(upgrade-job): use default value for missing values with helm 3.13 & 3.14 r=niladrih a=niladrih The underlying logic would need to change going forward to get the exhaustive set of values, but so far we're not using any of the values facing the errors for comparison, so they may be set to their default value when deserialising the source helm chart values. Ref: Helm issue 12936 Co-authored-by: Niladri Halder <[email protected]>
|
Build failed: |
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
479: fix(upgrade-job): use default value for missing values with helm 3.13 & 3.14 r=niladrih a=niladrih The underlying logic would need to change going forward to get the exhaustive set of values, but so far we're not using any of the values facing the errors for comparison, so they may be set to their default value when deserialising the source helm chart values. Ref: Helm issue 12936 Co-authored-by: Niladri Halder <[email protected]>
|
Build failed: |
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
479: fix(upgrade-job): use default value for missing values with helm 3.13 & 3.14 r=niladrih a=niladrih The underlying logic would need to change going forward to get the exhaustive set of values, but so far we're not using any of the values facing the errors for comparison, so they may be set to their default value when deserialising the source helm chart values. Ref: Helm issue 12936 Co-authored-by: Niladri Halder <[email protected]>
|
Build failed: |
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
479: fix(upgrade-job): use default value for missing values with helm 3.13 & 3.14 r=niladrih a=niladrih The underlying logic would need to change going forward to get the exhaustive set of values, but so far we're not using any of the values facing the errors for comparison, so they may be set to their default value when deserialising the source helm chart values. Ref: Helm issue 12936 Co-authored-by: Niladri Halder <[email protected]>
|
Build failed: |
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
479: fix(upgrade-job): use default value for missing values with helm 3.13 & 3.14 r=niladrih a=niladrih The underlying logic would need to change going forward to get the exhaustive set of values, but so far we're not using any of the values facing the errors for comparison, so they may be set to their default value when deserialising the source helm chart values. Ref: Helm issue 12936 Co-authored-by: Niladri Halder <[email protected]>
|
Build failed: |
|
bors merge |
|
Build succeeded: |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
482: Cherry-pick #479 r=niladrih a=niladrih This PR cherry-picks the commits from PR 479 Co-authored-by: Niladri Halder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying logic would need to change going forward to get the exhaustive set of values, but so far we're not using any of the values facing the errors for comparison, so they may be set to their default value when deserialising the source helm chart values.
Ref: Helm issue 12936