-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(callhome): add volume replica and state, pool, spdk managed disks and storage media metrics #434
Merged
bors-openebs-mayastor
merged 2 commits into
openebs:develop
from
datacore-vvarakantham:metrics
Jun 4, 2024
Merged
feat(callhome): add volume replica and state, pool, spdk managed disks and storage media metrics #434
bors-openebs-mayastor
merged 2 commits into
openebs:develop
from
datacore-vvarakantham:metrics
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datacore-vvarakantham
force-pushed
the
metrics
branch
from
March 15, 2024 10:17
0c5cc5b
to
450f492
Compare
datacore-vvarakantham
changed the title
feat(callhome): add volume replica and state metrics
feat(callhome): add volume replica and state, pool, spdk managed disks and storage media metrics
Mar 15, 2024
datacore-vvarakantham
force-pushed
the
metrics
branch
from
March 26, 2024 12:55
450f492
to
4137599
Compare
datacore-vvarakantham
force-pushed
the
metrics
branch
from
April 19, 2024 08:49
4137599
to
8dbde2e
Compare
datacore-vvarakantham
force-pushed
the
metrics
branch
from
May 15, 2024 10:55
8dbde2e
to
cb16210
Compare
orville-wright
approved these changes
May 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed use-case and feature completeness.
LGTM
Signed-off-by: Vandana Varakantham <[email protected]>
datacore-vvarakantham
force-pushed
the
metrics
branch
from
May 21, 2024 11:18
cb16210
to
c812284
Compare
datacore-vvarakantham
force-pushed
the
metrics
branch
2 times, most recently
from
May 29, 2024 10:03
ac80577
to
1c90567
Compare
tiagolobocastro
approved these changes
May 31, 2024
Signed-off-by: Vandana Varakantham <[email protected]>
datacore-vvarakantham
force-pushed
the
metrics
branch
from
May 31, 2024 09:16
1c90567
to
d408bf2
Compare
chriswldenyer
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable.
bors merge |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added volume replica and status metrics to callhome report
Added pool metrics per node to callhome report
Added mayastor managed disks to callhome report
Added storage media metrics to callhome report
Description
Motivation and Context
Regression
How Has This Been Tested?
Types of changes
Checklist: