Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(callhome): add volume replica and state, pool, spdk managed disks and storage media metrics #434

Merged

Conversation

datacore-vvarakantham
Copy link
Contributor

@datacore-vvarakantham datacore-vvarakantham commented Mar 13, 2024

Added volume replica and status metrics to callhome report

{
  "volumes":
      {
           "volume_replica_counts": {
              "one_replica": 1,
              "two_replicas": 4,
              "three_replicas": 0,
              "four_replicas": 0,
              "five_or_more_replicas": 0
           },
           "volume_state_counts": {
                "unknown": 0,
                "online": 5,
                "degraded": 0,
                "faulted": 0,
                "shutdown": 0
            }
     }
}

Added pool metrics per node to callhome report

"storage_nodes": {
    "nodes": {
      "node-1-153835": {
        "pools": [
          {
            "replicas": 0,
            "replicas_capacity": 0
          }
        ],
        "mayastor_managed_disks_count": 1
      },
      "node-0-153835": {
        "pools": [
          {
            "replicas": 0,
            "replicas_capacity": 0
          }
        ],
        "mayastor_managed_disks_count": 1
      }
    }
  },

Added mayastor managed disks to callhome report

"mayastor_managed_disks": {
    "disk_types": {
      "SSD": {
        "count": 2,
        "capacity": 21474836480
      }
    }
    

Added storage media metrics to callhome report

"storage_media": {
    "count": 9,
    "total_capacity_in_bytes": 526959770112,
    "disk_types": {
      "SSD": {
        "count": 6,
        "capacity": 523738546176
      },
      "Optical Drive": {
        "count": 3,
        "capacity": 3221223936
      }
    }
  },

Description

Motivation and Context

Regression

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.

@datacore-vvarakantham datacore-vvarakantham changed the title feat(callhome): add volume replica and state metrics feat(callhome): add volume replica and state, pool, spdk managed disks and storage media metrics Mar 15, 2024
call-home/src/common/constants.rs Outdated Show resolved Hide resolved
call-home/src/bin/callhome/main.rs Outdated Show resolved Hide resolved
call-home/src/bin/callhome/main.rs Outdated Show resolved Hide resolved
call-home/src/bin/callhome/main.rs Outdated Show resolved Hide resolved
call-home/src/bin/callhome/collector/report_models.rs Outdated Show resolved Hide resolved
call-home/src/bin/callhome/collector/report_models.rs Outdated Show resolved Hide resolved
call-home/src/bin/callhome/collector/report_models.rs Outdated Show resolved Hide resolved
Copy link

@orville-wright orville-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed use-case and feature completeness.
LGTM

Signed-off-by: Vandana Varakantham <[email protected]>
Copy link
Contributor

@chriswldenyer chriswldenyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@datacore-vvarakantham
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 2ac8433 into openebs:develop Jun 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants